Rongsong Shen
d26ff8870d
The buglog was one 27K-line JSON file whose fields covered only symptom,
root cause and fix, as free text: 2% of entries named the code version a
bug was found on, 12% the build profile, 36% a way to reproduce, and 58% of
the file was OpenWolf hook auto-detections ("Missing guard clause",
"Function not marked async" on .md files).
- .claude/skills/buglog/bug-record.md: the record standard. Eight
sections (Summary as the title, Description, Environment, Reproduction;
Root cause, Fix, Verification, References once fixed), each with the
content it must contain -- e.g. Environment needs the OS, the libc the
failing binary loads (from its ELF interpreter: glibc 2.42 in the nix
shell vs 2.40 on the host), toolchain, build profile and commit.
- .wolf/bugs/<id>.md: 500 records migrated from buglog.json; every field
verified to round-trip. They carry legacy: true and an explicit "not
recorded" where the old log had no such field; component derived from
file paths, severity from keywords (else unknown), fix_commits from
hashes in status_note/fix that git resolves (91 of 463 fixed).
- .wolf/buglog-archive.json: the 710 hook auto-detections, verbatim.
- .wolf/buglog.json is now an index generated from the records, keeping
the fields OpenWolf's hooks and `openwolf bug search` read.
- scripts/buglog.py rewritten: new (template + Environment collected from
the machine and --binary), check, status (refuses a status the record
doesn't support; fixed needs Root cause, Fix, Verification and
--commit hashes git resolves), note, recur, set, show, list, triage,
env, index. 29 unittest cases in scripts/tests/test_buglog.py.
- scripts/git-hooks/pre-commit runs `check --staged`: incomplete staged
records, a legacy record hand-changed to fixed without the fix-time
sections, a new record claiming legacy: true, or a stale index refuse
the commit.
- scripts/gitea-sync.py reads the records: issue body = the record's
sections plus linked fix commits (origin remote, GITEA_COMMIT_REPO to
override), and a body hash so an issue's text is refreshed when the
record changes.
- bug-1866 rewritten to the full standard as the worked example.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
38 lines
3.2 KiB
Markdown
38 lines
3.2 KiB
Markdown
---
|
|
id: "bug-1573"
|
|
status: "fixed"
|
|
status_updated: "2026-09-24"
|
|
status_note: ""
|
|
component: "scheduler"
|
|
severity: "unknown"
|
|
timestamp: "2026-08-18T01:20:00Z"
|
|
last_seen: "2026-09-19T09:00:00Z"
|
|
occurrences: 1
|
|
files: ["src/scheduler/src/core_events.c"]
|
|
tags: ["scheduler", "core_events.c", "Value_u_which", "union-type-confusion", "resupdate", "resource-value-verification", "task-4.1", "round-2-remediation"]
|
|
related: ["bug-1572"]
|
|
legacy: true
|
|
---
|
|
|
|
# bug-1573: resource-value-verification task 4.1 round-1 REJECTED by independent review: the RESVALS_DELTA…
|
|
|
|
## Description
|
|
resource-value-verification task 4.1 round-1 REJECTED by independent review: the RESVALS_DELTA TRACE logging in xce_core_push_events() assumed any non-string Value_u_which tag was Value_u_fvalue and read rv->val->u.fvalue unconditionally in the else branch -- Value_u_bvalue (and ivalue32/uvalue32/ivalue64/uvalue64) are real, reachable tags at this exact path (worker.c's mark_host_res() sets Value_u_bvalue for any XCE_VAL_BOOLEAN resource, routed through the same update_val_res()/resupdate RPC) that would read the wrong C union member.
|
|
|
|
## Environment
|
|
_Not recorded (migrated from buglog.json)._
|
|
|
|
## Reproduction
|
|
_Not recorded (migrated from buglog.json)._
|
|
|
|
## Root cause
|
|
Value_u_which (src/lib/controller.capnp.h:835-843) has 7 tags: ivalue32/uvalue32/ivalue64/uvalue64/svalue/fvalue/bvalue. Round-1's TRACE logic in the XCE_CORE_EVENT_RESVALS_DELTA case only distinguished svalue (explicit check) vs everything else (assumed fvalue, read .u.fvalue unconditionally in the else branch) -- a false dichotomy. Two directly-relevant precedents in this codebase already handle this correctly: update_val_res() (worker.c:107-117) explicitly checks `== Value_u_fvalue` with a generic 'non-numeric' fallback for anything else, and the sibling function core_apply_worker_resvals() 360 lines above in the SAME FILE (core_events.c:439-443) explicitly checks `== Value_u_fvalue` with no else at all (silent skip). Round-1 did not follow either precedent.
|
|
|
|
## Fix
|
|
Rewrote the RESVALS_DELTA TRACE block (core_events.c, XCE_CORE_EVENT_RESVALS_DELTA case, right after zarray_put) to explicit if/else-if: Value_u_svalue -> TRACE with value=%s; Value_u_fvalue -> TRACE with value=%f (reading .u.fvalue only once .which is confirmed); anything else (ivalue32/uvalue32/ivalue64/uvalue64/bvalue) -> silently skipped, mirroring core_apply_worker_resvals()'s established convention for the same ambiguity in this file (reviewer-approved Option B -- this feature's resource set is entirely fvalue/svalue today per resval_typeresolve.c). Verified: full scheduler build green (xce-build.sh scheduler), all 41 scheduler tests pass except the pre-existing unrelated bug-1560 (sched_admin_request_test's symlink-escape case); live smoke test via xce-deploy-ha + xce_test worker-context join/resupdate -n r15m -v 12345.5 confirmed unchanged output `resval applied host=task41r2-worker resource=r15m value=12345.500000` in scheduler.log, format-identical to round-1's (expected -- the fix only changes behavior for non-fvalue/non-svalue tags, which this smoke test doesn't exercise).
|
|
|
|
## Verification
|
|
_Not recorded (migrated from buglog.json)._
|
|
|
|
## References
|
|
- Related: bug-1572
|