Rongsong Shen
d26ff8870d
The buglog was one 27K-line JSON file whose fields covered only symptom,
root cause and fix, as free text: 2% of entries named the code version a
bug was found on, 12% the build profile, 36% a way to reproduce, and 58% of
the file was OpenWolf hook auto-detections ("Missing guard clause",
"Function not marked async" on .md files).
- .claude/skills/buglog/bug-record.md: the record standard. Eight
sections (Summary as the title, Description, Environment, Reproduction;
Root cause, Fix, Verification, References once fixed), each with the
content it must contain -- e.g. Environment needs the OS, the libc the
failing binary loads (from its ELF interpreter: glibc 2.42 in the nix
shell vs 2.40 on the host), toolchain, build profile and commit.
- .wolf/bugs/<id>.md: 500 records migrated from buglog.json; every field
verified to round-trip. They carry legacy: true and an explicit "not
recorded" where the old log had no such field; component derived from
file paths, severity from keywords (else unknown), fix_commits from
hashes in status_note/fix that git resolves (91 of 463 fixed).
- .wolf/buglog-archive.json: the 710 hook auto-detections, verbatim.
- .wolf/buglog.json is now an index generated from the records, keeping
the fields OpenWolf's hooks and `openwolf bug search` read.
- scripts/buglog.py rewritten: new (template + Environment collected from
the machine and --binary), check, status (refuses a status the record
doesn't support; fixed needs Root cause, Fix, Verification and
--commit hashes git resolves), note, recur, set, show, list, triage,
env, index. 29 unittest cases in scripts/tests/test_buglog.py.
- scripts/git-hooks/pre-commit runs `check --staged`: incomplete staged
records, a legacy record hand-changed to fixed without the fix-time
sections, a new record claiming legacy: true, or a stale index refuse
the commit.
- scripts/gitea-sync.py reads the records: issue body = the record's
sections plus linked fix commits (origin remote, GITEA_COMMIT_REPO to
override), and a body hash so an issue's text is refreshed when the
record changes.
- bug-1866 rewritten to the full standard as the worked example.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
38 lines
2.6 KiB
Markdown
38 lines
2.6 KiB
Markdown
---
|
|
id: "bug-1599"
|
|
status: "fixed"
|
|
status_updated: "2026-09-24"
|
|
status_note: "sim_loop.c comment reworded"
|
|
component: "scheduler"
|
|
severity: "unknown"
|
|
timestamp: "2026-08-20T02:50:00Z"
|
|
last_seen: "2026-09-19T09:00:00Z"
|
|
occurrences: 1
|
|
files: ["src/scheduler/testsuite/test_no_bare_printf.c (new regression test) flags src/scheduler/src/sim_loop.c"]
|
|
tags: ["scheduler", "test-only", "false-positive", "sim_loop.c", "test_no_bare_printf", "text-scan", "regression-test"]
|
|
related: []
|
|
legacy: true
|
|
---
|
|
|
|
# bug-1599: sched_no_bare_printf_test / test_scheduler_src_has_no_bare_printf_calls FAIL…
|
|
|
|
## Description
|
|
sched_no_bare_printf_test / test_scheduler_src_has_no_bare_printf_calls FAIL: '.../scheduler/src/sim_loop.c calls bare printf() -- xce_scheduler link-wraps printf ...' -- even though sim_print_decision() in sim_loop.c already correctly uses fprintf(stdout, ...) for all 3 PEND/DISPATCH/PREEMPT lines (verified via grep: lines 398/402/406 all fprintf(stdout, ...), zero bare printf( calls in actual code).
|
|
|
|
## Environment
|
|
_Not recorded (migrated from buglog.json)._
|
|
|
|
## Reproduction
|
|
_Not recorded (migrated from buglog.json)._
|
|
|
|
## Root cause
|
|
The new regression test's scan_dir_for_bare_printf()/contains_bare_printf_call() (test_no_bare_printf.c) is a naive whole-file text scan with NO comment/string-literal awareness (documented as such in its own header comment, matching test_core_isolation.c's precedent). The doc comment directly above sim_print_decision() in sim_loop.c (lines 375-387, added as part of this same fix, explaining WHY fprintf(stdout,...) is used instead of printf()) contains the literal prose substrings ' plain printf() (2026-08-20 fix)' (line 375) and ' plain printf() call' (line 377) -- both have a space immediately before 'printf(', which the scanner's rule (char before 'printf(' must not be letter/digit/underscore) matches as a bare-printf violation. The scanner cannot distinguish prose describing printf() from an actual call to it.
|
|
|
|
## Fix
|
|
NOT YET FIXED -- reported to caller for triage per explicit instruction not to fix. Likely fix: reword the sim_loop.c doc comment (lines 375/377) to avoid the literal pattern '<space>printf(' immediately -- e.g. write it as "printf" and "(" separately, or reference the wrapped __wrap_printf() symbol name instead of the bare word, or otherwise break up the substring so the naive scanner does not match it. Do NOT weaken the scanner itself to add comment-awareness without considering that test_core_isolation.c deliberately uses the same simple/strict genre.
|
|
|
|
## Verification
|
|
_Not recorded (migrated from buglog.json)._
|
|
|
|
## References
|
|
_Not recorded (migrated from buglog.json)._
|