Rongsong Shen
d26ff8870d
The buglog was one 27K-line JSON file whose fields covered only symptom,
root cause and fix, as free text: 2% of entries named the code version a
bug was found on, 12% the build profile, 36% a way to reproduce, and 58% of
the file was OpenWolf hook auto-detections ("Missing guard clause",
"Function not marked async" on .md files).
- .claude/skills/buglog/bug-record.md: the record standard. Eight
sections (Summary as the title, Description, Environment, Reproduction;
Root cause, Fix, Verification, References once fixed), each with the
content it must contain -- e.g. Environment needs the OS, the libc the
failing binary loads (from its ELF interpreter: glibc 2.42 in the nix
shell vs 2.40 on the host), toolchain, build profile and commit.
- .wolf/bugs/<id>.md: 500 records migrated from buglog.json; every field
verified to round-trip. They carry legacy: true and an explicit "not
recorded" where the old log had no such field; component derived from
file paths, severity from keywords (else unknown), fix_commits from
hashes in status_note/fix that git resolves (91 of 463 fixed).
- .wolf/buglog-archive.json: the 710 hook auto-detections, verbatim.
- .wolf/buglog.json is now an index generated from the records, keeping
the fields OpenWolf's hooks and `openwolf bug search` read.
- scripts/buglog.py rewritten: new (template + Environment collected from
the machine and --binary), check, status (refuses a status the record
doesn't support; fixed needs Root cause, Fix, Verification and
--commit hashes git resolves), note, recur, set, show, list, triage,
env, index. 29 unittest cases in scripts/tests/test_buglog.py.
- scripts/git-hooks/pre-commit runs `check --staged`: incomplete staged
records, a legacy record hand-changed to fixed without the fix-time
sections, a new record claiming legacy: true, or a stale index refuse
the commit.
- scripts/gitea-sync.py reads the records: issue body = the record's
sections plus linked fix commits (origin remote, GITEA_COMMIT_REPO to
override), and a body hash so an issue's text is refreshed when the
record changes.
- bug-1866 rewritten to the full standard as the worked example.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
3.1 KiB
| id | status | status_updated | status_note | component | severity | timestamp | last_seen | occurrences | files | tags | related | legacy | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| bug-1601 | fixed | 2026-09-24 | scheduler | unknown | 2026-08-20T07:26:00Z | 2026-09-19T09:00:00Z | 1 |
|
|
|
true |
bug-1601: User request: info resource/info worker did not distinguish consumable from non-consumable…
Description
User request: info resource/info worker did not distinguish consumable from non-consumable resources -- repl_info_worker_one() showed a fabricated total=/available= pair for EVERY numeric per-worker resource regardless of XCE_RESF_CONSUMABLE, and repl_info_resource_one() never reported a used/in-use amount for a CONSUMABLE GLOBAL/SHARED resource at all; the resource definition line was also missing ordtype.
Environment
Not recorded (migrated from buglog.json).
Reproduction
Not recorded (migrated from buglog.json).
Root cause
repl_info_worker_one() unconditionally computed/printed total=avail+inUse available=avail for any Value_u_fvalue resval, never checking XCE_RESF_CONSUMABLE -- a non-consumable numeric attribute (nothing ever allocates against it) got a misleading total/available split instead of a single current value. repl_info_resource_one() (the GLOBAL/SHARED case) only ever read core->sharedInst (the available pool) and never core->sharedInUse (the parallel in-use pool that already exists and is populated by the real resource-accounting code, resource.c), so a CONSUMABLE cluster-wide resource never showed how much was in use. The definition line also omitted xce_resource_t.ordtype (INCR/DECR/NA).
Fix
repl_info_resource_one(): added ordtype= to the definition line; for a GLOBAL/SHARED resource additionally flagged XCE_RESF_CONSUMABLE, the numeric value line now also reports used= (read from core->sharedInUse at the same idx) alongside value= (avail+used); non-consumable stays a single value= line. repl_info_worker_one(): the per-resource numeric line now looks up the matching xce_resource_t (by idx) from the already-built res_arr and gates the value/used split on XCE_RESF_CONSUMABLE -- consumable prints value=avail+used used=inUse (renamed from the old total=/available= labels for consistency with the resource-level display), non-consumable prints a single value=avail line. Added test_info_resource_reports_consumable_value_and_used and test_info_worker_reports_consumable_value_and_used (new, seed core->sharedInUse / worker->resInUse directly via dup_val()+zarray_put, mirroring the allocation pattern the real accounting code and core_events.c already use); updated 3 pre-existing tests whose asserted strings changed shape (test_info_worker_reports_resource_values, test_info_resource_reports_string_value, test_info_resource_named_lookup_reports_host_based_note). Full scheduler suite: 42/43 Ok, only the pre-existing unrelated bug-1560 failure remains.
Verification
Not recorded (migrated from buglog.json).
References
- Related: bug-1590, bug-1593