Rongsong Shen
d26ff8870d
The buglog was one 27K-line JSON file whose fields covered only symptom,
root cause and fix, as free text: 2% of entries named the code version a
bug was found on, 12% the build profile, 36% a way to reproduce, and 58% of
the file was OpenWolf hook auto-detections ("Missing guard clause",
"Function not marked async" on .md files).
- .claude/skills/buglog/bug-record.md: the record standard. Eight
sections (Summary as the title, Description, Environment, Reproduction;
Root cause, Fix, Verification, References once fixed), each with the
content it must contain -- e.g. Environment needs the OS, the libc the
failing binary loads (from its ELF interpreter: glibc 2.42 in the nix
shell vs 2.40 on the host), toolchain, build profile and commit.
- .wolf/bugs/<id>.md: 500 records migrated from buglog.json; every field
verified to round-trip. They carry legacy: true and an explicit "not
recorded" where the old log had no such field; component derived from
file paths, severity from keywords (else unknown), fix_commits from
hashes in status_note/fix that git resolves (91 of 463 fixed).
- .wolf/buglog-archive.json: the 710 hook auto-detections, verbatim.
- .wolf/buglog.json is now an index generated from the records, keeping
the fields OpenWolf's hooks and `openwolf bug search` read.
- scripts/buglog.py rewritten: new (template + Environment collected from
the machine and --binary), check, status (refuses a status the record
doesn't support; fixed needs Root cause, Fix, Verification and
--commit hashes git resolves), note, recur, set, show, list, triage,
env, index. 29 unittest cases in scripts/tests/test_buglog.py.
- scripts/git-hooks/pre-commit runs `check --staged`: incomplete staged
records, a legacy record hand-changed to fixed without the fix-time
sections, a new record claiming legacy: true, or a stale index refuse
the commit.
- scripts/gitea-sync.py reads the records: issue body = the record's
sections plus linked fix commits (origin remote, GITEA_COMMIT_REPO to
override), and a body hash so an issue's text is refreshed when the
record changes.
- bug-1866 rewritten to the full standard as the worked example.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2.8 KiB
| id | status | status_updated | status_note | component | severity | timestamp | last_seen | occurrences | files | tags | related | fix_commits | legacy | |||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| bug-1481 | fixed | 2026-09-24 | controller | unknown | 2026-07-29T07:05:00Z | 2026-09-19T09:00:00Z | 1 |
|
|
|
|
true |
bug-1481: raft-adapter-conformance systematic audit finding (not yet fixed): vote_ep_err_handler…
Description
raft-adapter-conformance systematic audit finding (not yet fixed): vote_ep_err_handler (ha.c:7564-7608), the shared on_err handler wired onto both real-vote and PreVote endpoints (ha.c:688-689, 827-828), handles post-connect endpoint failures (RDHUP/SSL error/remote close arriving after connect+monitor succeeded but before a reply) by calling the legacy handle_request_vote_reply directly instead of routing through vote_reply_dispatch / pre_vote_reply_dispatch (the production tally path fixed by bug-1423/1424 for connect-time and monitor-time failures only).
Environment
Not recorded (migrated from buglog.json).
Reproduction
Not recorded (migrated from buglog.json).
Root cause
Reopens the bug-1423/1424 defect class (vote-request send failure must reach the reply tally) for one failure window the original fix did not cover: connect/iomgr_monitor failures were fixed, but a failure arriving after a successful connect+monitor (before any reply) still bypasses the tally via the legacy path. Effect is bounded (election_timeout_ms / PreVote round timeout still fire), not a permanent deadlock, but the fast all-replied quorum-decision path is structurally unreachable for this failure mode.
Fix
FIXED (2026-07-29, ~13:53, commit fce73b5b "feat(raft-adapter-conformance): route post-connect vote/PreVote failures to production tally"). vote_ep_err_handler split into a real-vote handler and a new pre_vote_ep_err_handler; each now routes a post-connect election-phase failure through the same production tally path used for connect-time failures (vote_reply_dispatch / pre_vote_reply_dispatch) instead of the legacy handle_request_vote_reply. Landed as raft-adapter-conformance tasks 3.1-3.2 (see tasks.md), tested in test_ha_vote_send.c, confirmed live in task 7.4's soak. This buglog entry's original 'Not yet fixed' note (07:05 same day) predates the fix landing by ~6.8h and was never updated -- code is fixed, only this log entry was stale.
Verification
Not recorded (migrated from buglog.json).
References
- Related: bug-1423