myxce/.wolf/bugs/bug-1946.md

id	status	status_updated	status_note	component	severity	timestamp	last_seen	occurrences	files	tags	related	fix_commits	gitea_issue	gitea_synced_status	gitea_synced_hash
bug-1946	fixed	2026-10-10		apiserver	security	2026-10-10T08:15:01Z	2026-10-10T08:15:01Z	1	src/frontend/apiserver/controllers/auth.go src/frontend/apiserver/middleware/validatehandler.go	apiserver security jwt		4ce4f0b7	377	fixed	187fd106248e

bug-1946: apiserver logout does not revoke the token: it stays valid until expiry

Description

Observed: (source reading, .kiro/reviews/project-gap-review-2026-10-10.md (P0); to be confirmed by a failing test before the fix) Logout deletes a token file (controllers/auth.go:69-95) that token validation never reads (middleware/validatehandler.go:101-116).

Expected: After logout the token is rejected. Impact: Security: a leaked token keeps working for up to 24 h after logout. Found by: review: .kiro/reviews/project-gap-review-2026-10-10.md (P0)

Environment

• OS: no /etc/os-release; Docker container; NixOS kernel; kernel Linux 6.18.33 x86_64
• libc: glibc 2.42-47 (interpreter /nix/store/wb6rhpznjfczwlwx23zmdrrw74bayxw4-glibc-2.42-47/lib/ld-linux-x86-64.so.2)
• Toolchain: gcc (GCC) 15.2.0, meson 1.9.1
• Build: asan (xce.build)
• Code: scheduler-framework @ 94472ee3-dirty
• Deployment: any (found by source reading; the failing test that confirms it is named in Verification)

Reproduction

1. Log in, log out, call any API with the old token.
2. The call succeeds.

• Frequency: deterministic (by code reading; confirmed by the RED test of the fix)
• Evidence: the code sites quoted in Description; no logs kept.

Root cause

AuthController.Logout (controllers/auth.go) only removed a token file that token validation (middleware/validatehandler.go) never reads.

Fix

New controllers/token_revocation.go: revoked token IDs kept until expiry, purged on each revocation; generateJWT sets a random jti; tokens without one are revoked by hash; new ParseTokenClaims (used by ValidateHandler, RequirePermission, GetUsernameFromToken) rejects revoked tokens. Per process only (not persisted or shared). Follow-up: xcecli logout never calls the logout API.

Verification

• Test: TestLogout_RevokesToken (middleware/validatehandler_test.go): RED after logout: status = 200, want 401, GREEN after; plus TestTokenRevocations_ExpiryAndPurge, TestIntegration_PostLogoutTokenRejected.
• Suites: xce-build.sh all asan xce.build --incremental on the merged branch, 2026-10-10: all C suites Ok 155 / Fail 0, frontend Go unit tests ok, xceadmin tests ok; apiserver CGO_ENABLED=0 go test ./... (incl. middleware, router, cmd) ok
• Live: n/a: unit/fixture-level verification only; no live deployment was run (follow-up)

References

• Fix commit: 4ce4f0b7 (on scheduler-framework; worker-branch original in the merge)
• Review: .kiro/reviews/project-gap-review-2026-10-10.md