docs(buglog): log P0 defects from the 2026-10-10 review (bug-1936..bug-1952)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

2026-10-10 08:15:28 +00:00

2.2 KiB

Raw Blame History

status

status_updated

status_note

component

severity

timestamp

last_seen

occurrences

files

bug-1949: apiserver RequirePermission and IP whitelist write an error but do not abort the request

Description

Observed: (source reading, .kiro/reviews/project-gap-review-2026-10-10.md (P0); to be confirmed by a failing test before the fix) On a bad token RequirePermission returns an error response without Abort() (controllers/rbac_check.go:119-122); the IP whitelist does the same for an invalid client IP (middleware/whitelist.go:130-132); ReturnError never aborts (controllers/response.go:30-37).

Expected: A failed middleware check stops the request before the handler runs. Impact: Security: the handler may still run after an authorization failure. Found by: review: .kiro/reviews/project-gap-review-2026-10-10.md (P0)

Environment

OS: no /etc/os-release; Docker container; NixOS kernel; kernel Linux 6.18.33 x86_64
libc: glibc 2.42-47 (interpreter /nix/store/wb6rhpznjfczwlwx23zmdrrw74bayxw4-glibc-2.42-47/lib/ld-linux-x86-64.so.2)
Toolchain: gcc (GCC) 15.2.0, meson 1.9.1
Build: asan (xce.build)
Code: scheduler-framework @ 94472ee3-dirty
Deployment: any (found by source reading; the failing test that confirms it is named in Verification)

Reproduction

Call a RequirePermission-guarded route with a malformed token claim (see the code path above) and observe the handler running.

Frequency: deterministic (by code reading; confirmed by the RED test of the fix)
Evidence: the code sites quoted in Description; no logs kept.

Root cause

TODO: required for fixed/partial

Fix