wdgzyjx/myxce
1
0
Fork 0
forked from lei.chen/myxce
Code Pull requests Activity
myxce/src/docs/apiserver-backend-tasks.md
Rongsong Shen bc3103a6d5 feat: P1-1 handle resource value push via OPCode_notify 
Add OPCode_notify handler in go_push_handler top-level switch
(not inside handlePush) to receive resource value updates from
the controller via xce_notify_data_t/schedUpdateResvals.

- Add 8 CGO union accessors for xce_val_t (which, i32, i64,
  u32, u64, fval, str, bool) since CGO cannot access union fields
- Add handleNotifyData() dispatching NotifyData_data_schedUpdateResvals
  events, iterating xce_resval_list_t and calling cResvalToDistribution
- Add cResvalToDistribution in convert.go with 7 separate switch
  cases for Value_u_* union discriminants (no combining i32/i64)
- Add rawResvalData + rawResvalToDistribution pure-Go version
  in convert_pure.go for testability without CGO
- Add 10 TDD tests covering all 7 value types, nil val guard,
  unknown discriminant, and boolean false
- All 42 backend tests passing
2026-04-17 13:54:03 +00:00

8.5 KiB
Raw Blame History

API Server Backend Enhancement — Task Tracker

Status Legend

  • Completed
  • Pending
  • [>] In Progress (blocked)

P0-1: Handle Cluster Config Push

  • #1 P0-1a: Add HostConfig + Cluster fields to models

    • models/clusters.go — Added HeartbeatInterval, Vcpus, InactiveHeartbeatCount to ClusterInfo
    • models/hosts.go — Changed HostStateStr(0) from "OK" to "UNKNOWN"
    • models/clusters_test.go — New: verifies new fields serialize + existing fields unchanged
    • models/hosts_test.go — New: verifies HostStateStr for zero, flags, non-flag, combined
    • All 15 tests passing

  • #2 P0-1b: Add pure Go conversion functions + TDD tests

    • backend/convert_pure.go — Added rawHostConfigData + rawHostConfigToModel(), rawClusterData + rawClusterToModel()
    • backend/convert_test.go — 8 new table-driven tests: zero-value ints, empty strings, normal values, worker/config-sourced field isolation
    • TODO(dispatchwindow) comment added per plan spec
    • DisptWindow guard test added to catch accidental future CGO layer changes
    • All 26 backend tests passing

  • #3 P0-1c: Add CGO conversion layer in convert.go

    • backend/convert.go — Added cHostConfigToModel(), cClusterConfHostConfigs(), cClusterConfToClusterInfo()
    • cResdefToModel intentionally skipped — xce_resdef_t doesn't exist in C codebase and ResourceInfo has no store/consumer (YAGNI); existing cResourceToModel → ResourceDefinitionInfo already handles config push
    • cClusterConfResources already existed — no change needed
    • CGO compilation verified passing
    • All unit tests still passing

  • #4 P0-1d: Implement handlers with partial merge + TDD

    • backend/notification.go — Added OnClusterUpdated(cluster *models.ClusterInfo) and OnHostConfigUpdated(host *models.HostInfo) to NotificationHandler interface
    • backend/handler.go — Implemented partial-merge OnClusterUpdated (preserves Version, Status, ControllerName, NumServers, Resources, HostTypes, HostModels, ClusterAdmins), OnHostConfigUpdated (preserves HostStatus, CPUFactor, NumCPUs, NumCores, NumThreads, MaxMem, MaxSwap, MaxTmp, NumDisk, NumRun, NumSSusp, NumUSusp, NumDone, Topology, SchedStop), fixed OnHostUpdated (preserves HostModel, HostType, MaxSlot, DisptWindow via two-value Get())
    • backend/handler_test.go — 6 new tests: new host, partial merge for each of OnHostConfigUpdated, OnClusterUpdated, OnHostUpdated
    • All backend tests passing (32 total)

  • #5 P0-1e: Expand handleConfigPush (unblocked)

    • backend/clib.go — Expand handleConfigPush() to call cClusterConfHostConfigs() and cClusterConfToClusterInfo()
    • Call gHandler.OnHostConfigUpdated() per host config, gHandler.OnClusterUpdated() for cluster settings

P0-2: Host Control via Backend

  • #6 P0-2a: C-side plumbing for host control

    • schema/controller.capnp — Added HostControl struct + hostctrlmsg @21
    • include/typemap.h — Added xce_hostctrl_t* hostctrlmsg; to body union (after @20 clrpreasonmsg, matching capnp ordinal)
    • include/client.h — Added xcecli_hostctrl() declaration
    • include/xceapi.h — Added xce_hostctrl() declaration
    • include/request.h — Added xce_hostctrl_req() declaration
    • lib/client.c — Implemented xcecli_hostctrl()
    • lib/xceapi.c — Implemented xce_hostctrl() with cbuf_get() wait
    • lib/request.c — Implemented xce_hostctrl_req() (validates HOST_OPEN/HOST_CLOSE only, rejects HOST_TAG/UNTAG)
    • lib/helper.c — Added Request_body_hostctrlmsg case to xce_request_body() + xce_request_msg_name()
    • controller/cluster.c — Added OPCode_hostcontrol case → do_hostcontrol_op()
    • controller/worker.c — Implemented do_hostcontrol_op() calling worker_ctrl(); fixed pre-existing goto clean bug that leaked write lock + reference count
    • controller/include/cluster.h — Declared do_hostcontrol_op()
    • lib/testsuite/test_request.c — 8 TDD validation tests (null ep/ctrl/hostname, empty hostname, HOST_DO_NONE no-op, HOST_TAG/UNTAG reject, negative action)
    • Regenerated capnp via ninja -C build

  • #7 P0-2b: Implement Go-side ControlHost + fix allFlag race

    • backend/clib.go — Replaced ControlHost() stub with real xcecli_hostctrl() call; follows ControlQueue pattern exactly
    • backend/control_host_test.go — New: stub signature + errNoCGO test (guarded //go:build !cgo)
    • controllers/hosts.go — Removed var allFlag bool from package scope; preCheckHostControlRequest now returns (bool, error); ControlHost uses hostActionMap with explicit !exists guard (mirrors ControlQueue pattern)
    • controllers/queues.go — preCheckQueueControlRequest now returns (bool, error); ControlQueue receives allFlag locally
    • controllers/host_control_test.go — 5 new tests: allFlag true/false, concurrent no-race (50 goroutines), invalid action, comment-too-long
    • controllers/queue_control_test.go — 5 new tests: same coverage for queues
    • All tests passing (make test)

  • #8 P0-2c: Register routes + RBAC for host control/select

    • router/routers.go — POST /xce/v1/hosts/control → RBAC host:control (cluster_admin)
    • router/routers.go — POST /xce/v1/hosts/select → RBAC host:view (all authenticated)
    • config/rbac.yaml — host:control and host:view action entries already present
    • controllers/rbac_check_test.go — 3 new TDD tests: TestRBAC_HostControl_ClusterAdminOnly, TestRBAC_HostView_BasicUserHasAccess, TestRBAC_HostControl_DomainTypeIsAll
    • All tests passing (controllers package)

  • #9 P0-2d: Update stub.go with new function stubs

    • backend/stub.go — Added StartHeartbeat(_ context.Context){}, SetHeartbeatInterval(_ int){}, EvalSelectForHost(_, _ string) error (returns errNoCGO), Cleanup(){}, added "context" to imports
    • backend/stub_funcs_test.go — 4 TDD tests: TestStartHeartbeat_StubNoOp, TestSetHeartbeatInterval_StubNoOp (3 edge values), TestEvalSelectForHost_StubErrNoCGO, TestCleanup_StubNoOp
    • All backend tests passing

P1-1: Handle Resource Value Push

  • #10 P1-1: Handle resource value push (OPCode_notify)
    • backend/clib.go — Added 8 CGO val union helpers (xce_val_which, xce_val_i32, i64, u32, u64, fval, str, bool)
    • backend/clib.go — Added OPCode_notify case at top-level switch in go_push_handler() (NOT inside handlePush())
    • backend/clib.go — Added handleNotifyData() for NotifyData_data_schedUpdateResvals
    • backend/convert.go — Added cResvalToDistribution() — switches on Value_u_* constants, all 7 cases separate
    • backend/convert_pure.go — Added rawResvalData struct + rawResvalToDistribution() pure-Go version
    • backend/convert_test.go — 10 TDD tests covering all 7 value types, nil val, unknown discriminant, boolean false
    • All 42 backend tests passing (CGO_ENABLED=0 go test ./backend/ -v)

P1-2: Host Resource Requirement Select

  • #11 P1-2a: C select expression parser (PEG + eval)

    • include/resreq.h — Replace empty xce_resreq_select_ with expression tree types, add enums, add extern declarations
    • lib/xce_select.peg — New PEG grammar for select boolean expressions (right-recursive)
    • lib/resreq.c — Implement parse_select(), eval_select(), free_select(); update kill_primary_resreq()
    • lib/meson.build — Add xce_select.peg to explicit source list

  • [>] #12 P1-2b: Go EvalSelectForHost + FilterHostByResReqSelect (blocked by #11)

    • backend/clib.go — Add EvalSelectForHost() using cgo.Handle for callback context, add #include "resreq.h", extern declarations, xce_select_destroy helper
    • controllers/hosts.go — Implement FilterHostByResReqSelect, update preCheckHostRequest() limit from 4094→1024 bytes

P1-3: Heartbeat Keep-Alive

  • #13 P1-3: Heartbeat keep-alive implementation
    • backend/clib.go — Add heartbeatIntervalSecs int32 (default 30), SetHeartbeatInterval(), heartbeatFn var, StartHeartbeat(ctx context.Context)
    • backend/handler.go — OnClusterUpdated calls SetHeartbeatInterval(cluster.HeartbeatInterval) after store update
    • cmd/main.go — Call backend.StartHeartbeat(ctx) after backend.RegisterToBackend(...)

Final

  • [>] #14 Build and test verification (blocked by all others)
    • make test in src/frontend/ passes
    • ninja -C build for C components passes
    • RBAC verification
    • Input safety verification (1024-byte limit, 256-host limit)